Calling Stored Procedures from Entity Framework Core 3.0

c# entity-framework-core


I have a number of stored procedures which all have a number of parameters and execute a complex select statement where the results exactly match a table or view. I would like to map the result set to Entities. This worked fine with version 2.2 but I can't get it to work with EFCore 3.0.

My code is this:

SqlParameter regionId = p.RegionId.HasValue && p.RegionId.Value != 0 ? new SqlParameter( "@RegionId", p.RegionId.Value ) : new SqlParameter( "@RegionId", System.DBNull.Value );

… (other parameters omitted for clarity, but all SqlParameters)

var contacts = await _context.PersonSearchViewSearch.FromSqlRaw( "EXECUTE [dbo].[PersonSearchView_Search] @RegionId, @RecordId, @Surname, @Firstname, @PostCode, @HomePhone, @WorkPhone, @MobilePhone, @EMail, @IncludePatients, @IncludeContacts, @IncludeEnquiries, @AllowedRegions, @IncludeOtherRegions, @IncludeDisallowedRegions, @FirstNameMP, @FirstNameAltMP, @SurnameMP, @SurnameAltMP", regionId, id, surname, forename, postcode, homePhone, workPhone, mobilePhone, email,includePatients, includeContacts, includeEnquiries, allowedRegions, includeOtherRegions,includeDisallowedRegions, forenameMP, forenameAltMP, surnameMP, surnameAltMP ).ToListAsync();

In EF Core 3.0 this generates the following SQL (which isn't valid):

exec sp_executesql N'SELECT [p].[Address1], [p].[Address2], [p].[Address3], [p].[Address4], [p].[CarerOrProfessionalId], [p].[City], [p].[ContactId], [p].[Discriminator], [p].[EMail], [p].[EnquiryId], [p].[FirstName], [p].[FirstNameAltMP], [p].[FirstNameMP], [p].[HomePhone], [p].[MobilePhone], [p].[PatientId], [p].[PostCode], [p].[PreferredPhone], [p].[PreferredPhoneNo], [p].[RegionId], [p].[RegionName], [p].[SalutationId], [p].[SearchId], [p].[Surname], [p].[SurnameAltMP], [p].[SurnameMP], [p].[Title], [p].[WorkPhone], [p].[IsAllowed], [p].[IsPrimaryRegion]
    EXECUTE PersonSearchView_Search @RegionId,@RecordId,@Surname,@Firstname,@PostCode,@HomePhone,@WorkPhone,@MobilePhone,@EMail,@IncludePatients,@IncludeContacts,@IncludeEnquiries,@AllowedRegions,@IncludeOtherRegions,@IncludeDisallowedRegions,@FirstNameMP,@FirstNameAltMP,@SurnameMP,@SurnameAltMP
) AS [p]
WHERE [p].[Discriminator] = N''PersonSearchViewSearch''',N'@RegionId int,@RecordId nvarchar(4000),@Surname nvarchar(6),@Firstname nvarchar(4000),@PostCode nvarchar(4000),@HomePhone nvarchar(4000),@WorkPhone nvarchar(4000),@MobilePhone nvarchar(4000),@EMail nvarchar(4000),@IncludePatients bit,@IncludeContacts bit,@IncludeEnquiries bit,@AllowedRegions nvarchar(8),@IncludeOtherRegions bit,@IncludeDisallowedRegions bit,@FirstNameMP nvarchar(4000),@FirstNameAltMP nvarchar(4000),@SurnameMP nvarchar(3),@SurnameAltMP nvarchar(3)',@RegionId=1,@RecordId=NULL,@Surname=N'smith%',@Firstname=NULL,@PostCode=NULL,@HomePhone=NULL,@WorkPhone=NULL,@MobilePhone=NULL,@EMail=NULL,@IncludePatients=1,@IncludeContacts=1,@IncludeEnquiries=1,@AllowedRegions=N'1,2,6,11',@IncludeOtherRegions=0,@IncludeDisallowedRegions=0,@FirstNameMP=NULL,@FirstNameAltMP=NULL,@SurnameMP=N'SM0',@SurnameAltMP=N'XMT'

The stored procedures are too complex to try and write with Linq to SQL.

The only workaround I currently have is to go back to SqlCommand/SqlDataReader method, but this requires writing a lot of additional code to map the results back into an entity.

Is there a better way to do this in EF Core 3.0?

11/6/2019 4:52:09 AM

Popular Answer

For anyone else coming across this issue, I tracked it down to my definition of "PersonSearchViewSearch" being a derived class from another view. I changed the definition to be a standalone class by copying all fields from the base class and this resolved the issue.

This changed the generated SQL to be a simple Execute statement rather than a Select from an Execute.

(EF Core 2.2 was happy with me using a derived class).

11/6/2019 4:20:55 AM

Related Questions


Licensed under: CC-BY-SA with attribution
Not affiliated with Stack Overflow
Licensed under: CC-BY-SA with attribution
Not affiliated with Stack Overflow